Review issues

Module base_CCable

0064 — Cable evaluates the wave sum three times per segment and right-hand side

Module base_FlukeAnchor

0064 — Cable evaluates the wave sum three times per segment and right-hand side

0065 — Polyplate soil forces allocate on the heap on every right-hand side

Module base_TorpedoAnchor

0064 — Cable evaluates the wave sum three times per segment and right-hand side

0065 — Polyplate soil forces allocate on the heap on every right-hand side

Module fhsim_coribo

0006 — Point-versus-disk face contact: the disk's rotational Jacobian has the wrong sign

0009 — ConstraintSolver(double) starts hardware_concurrency threads, which makes small models many times slower; the affinity masks shift past their width

Module fhsim_marine_elements

0001 — `RbCable/Collision` is registered only in a commented-out line

0353 — The load-law validation pages are generated from tests that moved to fhsim_environment

Module marine_elements_Cable

0223 — Cable/* makes one flow query per element per RHS, each sampling every registered lumped wake

Module marine_elements_CableBranched

0223 — Cable/* makes one flow query per element per RHS, each sampling every registered lumped wake

Module marine_elements_CableRM

0314 — RbCable/Cable carries no added mass, so its wave excitation is Froude–Krylov only

Module marine_elements_Disk

0327 — HasJacobians of NetStructure and Disk depends on the contact state of the last OdeFcn call

Module marine_elements_MooringCable

0323 — The added-mass Coriolis term uses the element velocity, not the velocity relative to the water

0324 — No test of the MooringCable buoy element in waves

0326 — TrawlCable, MooringCable and RundDorg fix the water density at 1025 kg/m³

Module marine_elements_NetStructure

0027 — Three follow-ups left by the scalar-templated panel force core

0110 — Default load law misses lift at high solidity and the angle dependence of Rudi, Løland and Zhan (A6 disabled tests)

0122 — Sundials BDF with the default linear solver collapses the step in any transient (wake blend, load ramp)

0131 — Default law: replace the two-harmonic angle form with three harmonics, refitted to MF2022, Rudi, Løland and Zhan

0211 — The net file reader is quadratic in the number of panels: every attribute read resolves its path from the root

0319 — NetStructure's cable drag Jacobian uses the water density, not the element's air/water blend

0327 — HasJacobians of NetStructure and Disk depends on the contact state of the last OdeFcn call

0328 — NetStructure and NetStructureWithConstraints leak their elements and constraint solver at teardown

0329 — The BottomContact port test does not exercise the M_y and M_z moment terms

Module marine_elements_NetStructureABAQUS

0031 — The Windows-only NetStructureTest family (NetStructureTest, NetStructureABAQUS, NetStructureConstrained) has no test coverage

0081 — NetCableElementTest still puts sphere and disk mass and weight on the wrong end and splits disk drag as −pos and 1 − pos (Windows only)

Module marine_elements_NetStructureConstrained

0031 — The Windows-only NetStructureTest family (NetStructureTest, NetStructureABAQUS, NetStructureConstrained) has no test coverage

Module marine_elements_NetStructureTest

0031 — The Windows-only NetStructureTest family (NetStructureTest, NetStructureABAQUS, NetStructureConstrained) has no test coverage

0081 — NetCableElementTest still puts sphere and disk mass and weight on the wrong end and splits disk drag as −pos and 1 − pos (Windows only)

Module marine_elements_NetStructureWakeEffect

0163 — fhsim_aquaculture cannot build on fhsim_marine_elements 4 without a port, and the migration guide does not list what the port must change

Module marine_elements_NetStructureWithConstraints

0110 — Default load law misses lift at high solidity and the angle dependence of Rudi, Løland and Zhan (A6 disabled tests)

0121 — SimObject.NetStructureWithConstraints_SolverFrequency may be flaky

0131 — Default law: replace the two-harmonic angle form with three harmonics, refitted to MF2022, Rudi, Løland and Zhan

0211 — The net file reader is quadratic in the number of panels: every attribute read resolves its path from the root

0321 — NetStructureWithConstraints_CablesThreadIndependent no longer runs anything in parallel

0328 — NetStructure and NetStructureWithConstraints leak their elements and constraint solver at teardown

Module marine_elements_RundDorg

0323 — The added-mass Coriolis term uses the element velocity, not the velocity relative to the water

0326 — TrawlCable, MooringCable and RundDorg fix the water density at 1025 kg/m³

Module marine_elements_TrawlCable

0003 — `TrawlCable`'s `Heun_i` branch is commented out while `RundDorg`'s is live

0323 — The added-mass Coriolis term uses the element velocity, not the velocity relative to the water

0326 — TrawlCable, MooringCable and RundDorg fix the water density at 1025 kg/m³

Module marine_elements_WaveHull

0354 — WaveHull aliases waves shorter than twice the sample spacing