FhSim  3.1.0
Marine systems simulation
Loading...
Searching...
No Matches
0353 — The load-law validation pages are generated from tests that moved to fhsim_environment
ID 0353
Class DOCUMENTATION
Severity 1
Status ready

Models: —

Found: 2026-10-04 at 7194757, batch B3 of feature fluid-body-interaction (MARE-0351)

Evidence

  • tests/plot_validation.py:5, :52-67 and the page entries after them read the reports and gtest suites of tests/PanelLoadLaw_*_Test.cpp (PanelLoadLaw_MF2022, _Zhan, _Rudi, _Loland, _Consistency), which MARE-0351 deleted here: they are fhsim_environment's tests now (its tests/PanelLoadLaw_*_Test.cpp, ENV-0101), which write their reports into its own tests/out/.
  • The generated pages doc/user/validation/mf2022.md, zhan2006.md (its L8 part), rudi_loland.md and l9_fit.md, and the table in doc/user/validation/README.md, still show the run of 2026-10-03; the next regeneration here finds no such suites.
  • The guide "How to add a new load law" (DEVELOPING.md) now points to fhsim_environment paths, but fhsim_environment's DEVELOPING.md has no such guide.

Effect

The validation report of the laws cannot be regenerated in this repository; the pages are frozen at 4.0.0. The SimObject-level pages (S1 to S7: towed_panel_s1.md, lader2009.md, trawl.md, the S6/W9 part of zhan2006.md) stay here.

Possible fix

Move the law pages and their part of plot_validation.py to fhsim_environment (a doc/user/validation/ there, generated from its tests), keep the SimObject-level pages here and link the two; move the load-law guide of DEVELOPING.md with them.

Test that would prove it

python3 tests/plot_validation.py after a VALIDATION build regenerates every page listed in doc/user/validation/README.md without a missing suite; fhsim_environment regenerates the law pages.

Risk

Documentation only.