FhSim  3.1.0
Marine systems simulation
Loading...
Searching...
No Matches
0076 — ValuesDisplay excerpt is malformed XML and SimpleTrawlVessel.xml sets a Depth the vessel never reads
ID 0076
Class DOCUMENTATION
Severity 1
Status ready
Models Trawl/ValuesDisplay, Trawl/Vessel
Found 2026-09-26, OpenWiki pass
Decision needed

Evidence

  • src/trawl/ValuesDisplay.h:23-27: the second element of the configuration excerpt opens with </Lib Libname = "fishery" and closes with />. That is neither a start tag nor an end tag (an end tag takes no attributes), and Libname is misspelt for LibName. The first element (:14-22) is well formed.
  • examples/input/SimpleTrawlVessel.xml:19 sets Depth = "7" on the Trawl/Vessel. The vessel (ToVessel, built on TrawlVessel) reads Length, Breadth and Draught (src/trawl/TrawlVessel.cpp:36-38) and DepthScale (:50), never Depth; ToVessel.h:57 documents Draught. The file is the @include example of ToVessel.h:81 and the source of tests/in/Vessel/Vessel_in.xml and tests/out/Vessel/RendersWithoutMeshName/in.xml.

Effect

Readers only. Copying the ValuesDisplay excerpt gives a file that does not parse. The Depth in the vessel example is silently ignored; it has no numeric effect today only because the Draught default, Length / 10 = 7 m, happens to equal it. Someone changing Depth in a copy expects a different draught and gets none.

Possible fix

  • ValuesDisplay.h:23: <Lib LibName = "fishery".
  • SimpleTrawlVessel.xml:19: Draught = "7" (the same value, so no result changes). Check the two trimmed test inputs for the same key.

Test that would prove it

Parse the ValuesDisplay excerpt with an XML parser; an ExamplesLoad case, or an unknown- parameter warning, showing that SimpleTrawlVessel.xml sets only parameters the vessel reads.

Risk

None: the excerpt is a comment and the replacement Draught equals the default in force.