|
FhSim
3.1.0
Marine systems simulation
|
| ID | 0088 |
| Class | ARCHITECTURE |
| Severity | 1 |
| Status | blocked |
Models: —
Found: Review 2026-09-28: FISH-R-9 (remainder), I-11. 2026-09-28 review of feature/net-hydrodynamics at 73aa0c7 (worktrees/nethydro/review/fhsim_fishery.md and interactions.md); rechecked at 1e6770c; filed by phase K WP K4 (owner ruling R42 item 39)
Decision needed: Owner (Karl-Johan): 3.4.0 (as chosen in 1e6770c: fishery's own interface unchanged) or 4.0.0 (the review: removed input attribute and changed net loads)?
Review 2026-09-28: FISH-R-9 (severity 1, tracker scale) and the fishery part of interactions I-11 (severity 1).
Partly done by 1e6770c ("Consume the set from @sintef/testing: marine elements, environment and base,
version 3.4.0"): version.txt is 3.4.0 and the CHANGELOG section is [Unreleased] - 3.4.0 with a Dependencies entry ("fishery's own interface is unchanged"). The review recommended 4.0.0; that choice is what is left.
conanfile.py:42-43: fhsim_marine_elements/[>=4.0.0 <5], fhsim_environment/[>=4.0.0 <5] (was [^3.2.0]); version.txt 3.4.0.MaxAcceleration input from Seine/Cable (FISH-0080, R40); an input that still sets it runs without a warning (see fhsim_marine_elements MARE-0165, review I-14).doc/user/steady_tow.md §6 shows the law-dependent drag).fhsim/[^3.3.0] while the others require [^3.2.0]; it resolves, but raises the floor of any graph that includes fishery.A 3.x minor bump carries input and behaviour changes that semantic versioning puts in a major.
Release as 4.0.0 after base and ME (R37 order) and say so in the CHANGELOG, or keep 3.4.0 and state why.
After the decision: a test of the chosen behaviour.
Result changes only in the cases named above; check the regression baselines.