0078 — The 11 trawl inputs under `data/` still reference `Environment/Basic`, which no 3.x library registers

ID	0078
Class	DOCUMENTATION
Severity	2
Status	blocked

Models:

Found: 2026-09-27, net-hydrodynamics WP-D3 downstream check of ff17183

Decision needed: Are the data/trawl/ inputs maintained? If so, port them as FISH-0019 ported examples/input/, and say where TrawlPrepareStates0.txt (the start state of the morenot520 scenario) comes from; otherwise remove them.

Evidence

FISH-0019 replaced the Environment/Basic block in examples/input/ only. These 11 files under data/ still declare LibName = "base", SimObject = "Environment/Basic" (line of the SimObject), and each has one Environment.CurrentVel interconnection, which the 3.x Environment object has no port for (FISH-0019 resolution):

File	Line
data/trawl/demos/trawldoorcontrol/FoilControl.xml	8
data/trawl/demos/trawldoorcontrol/TrawlDoorControl.xml	15
data/trawl/demos/trawldoorcontrol/TrawlDoorControl2.xml	4
data/trawl/demos/trawldoorcontrol/TrawlDoorControlMovie.xml	28
data/trawl/demos/trawldoorcontrol/flume.xml	8
data/trawl/demos/trawldoorcontrol/flume2.xml	8
data/trawl/demos/trawldoorcontrol/flume3.xml	8
data/trawl/movies/trawl/morenot520/Trawl.xml	28
data/trawl/movies/trawl/morenot520/TrawlMovie.xml	29
data/trawl/movies/trawl/morenot520/TrawlPrepare.xml	5
data/trawl/movies/trawl/morenot520/TrawlSimple.xml	26

(grep -rln "Environment/Basic" data.) No 3.x library registers that class: ‘grep -rn 'Environment/Basic’ srcis empty in fhsim_base 4.0.1 (605dfa6), fhsim_environment 3.2.1 (ed364f5) and 4.0.0 (net-hydrodynamics integration9a196d1) and fhsim_marine_elements 3.2.1 and 4.0.0; fhsim_environment registers onlyEnvironmentfor the environment itself (src/fhsim_environment.cpp:16`).

Reproduced on 2026-09-27 from scratch copies of data/trawl/movies/trawl/morenot520/ (each with a SimObjectLibraries link to the playpen), FhSim v3.3.0-41a573bf:

• Trawl.xml exits 1 with "The simulation object of class "Environment/Basic" was not found" on the fishery main build (ff17183, fhsim_marine_elements 3.2.1 and fhsim_environment 3.2.x from the Conan cache) and on the wp/D3-downstream build (772310e, fhsim_marine_elements 4.0.0 and fhsim_environment 4.0.0 editables).
• TrawlPrepare.xml exits 1 with the same message (4.0.0 build).

Second defect in the same scenario: TrawlPrepare.xml:167 sets InitialStatesFile="TrawlPrepareStates0.txt", and no such file is in the repository (‘git log --all -- ’TrawlPrepareStates'is empty).TrawlMovie.xml:206reads TrawlPrepareStates1.txt, whichTrawlPrepare.xmlwrites. What FhSim does with a missing InitialStatesFilewas not observed, because both files fail at the environment first. So the morenot520 scenario has no committed settled start: WP-D3 had to runTrawl.xmlas a cold start from a scratch copy with the FISH-0019 environment block (fhsim_marine_elementsdoc/user/validation/downstream_fishery.md`).

Effect

None of the 11 inputs loads on FhSim 3.x as committed. Anyone using the morenot520 trawl or the trawl-door-control demos as a starting point, as the net-hydrodynamics downstream check did, must first edit the environment block, and the morenot520 chain (TrawlPrepare → TrawlMovie) cannot be reproduced from the repository.

Possible fix

Apply the FISH-0019 recipe to each file: an environment / Environment block with Waves.NumWaves = "0", the file's own Bathymetry.Depth and Current.Vector, and the Environment.CurrentVel interconnection deleted. Then either commit a TrawlPrepareStates0.txt or drop InitialStatesFile from TrawlPrepare.xml so it starts cold (that changes the scenario; owner's call). Alternatively remove the inputs if they are no longer used.

Test that would prove it

Run each of the 11 files headless from the playpen (a SimObjectLibraries link in its folder) for a short SimulationTime; each must set up without "was not found" and exit 0.

Risk

Input files only; they cannot load today, so no result moves.