FhSim  3.1.0
Marine systems simulation
Loading...
Searching...
No Matches
0050 — CHANGELOG and testing report say the tests need <tt>fhsim/3.2.0\@sintef/jaccheck</tt>; <tt>fhsim/3.2.0\@sintef/stable</tt> already has <tt>scopeOverrides</tt>
ID 0050
Class DOCUMENTATION
Severity 1
Status ready
Models —
Found 2026-09-26 OpenWiki pass, confirmed at 3882e45

Evidence

CHANGELOG.md:29-31 ([Unreleased], Changed): "**This needs an FhSim whose <tt>JacobianCheckConfig</tt> has <tt>scopeOverrides</tt>** (<tt>fhsim/3.2.0\@sintef/jaccheck</tt>); the tests no longer compile against <tt>fhsim/3.2.0\@sintef/stable</tt>." `doc/user/testing_report.md:65-66` repeats it: "Built against an FhSim that has <tt>JacobianCheckConfig::scopeOverrides</tt> (<tt>fhsim/3.2.0\@sintef/jaccheck</tt>)". conanfile.py:38 requires fhsim/[^3.2.0]@sintef/stable, and no file outside issues/resolved/, CHANGELOG.md and doc/user/testing_report.md names a jaccheck channel.

The requirement is the correct one; the two documents are stale:

  • The tests do need scopeOverrides, but only in two places now: tests/src/Template-Input_Test.cpp:21 and :39, jacobianConfig.scopeOverrides["Anc"].skip = true;. No other test uses it.
  • scopeOverrides and JacobianScopeOverride::skip came with fhsim commit b005ec27 (2026-09-24, "Check Jacobians along the trajectory, off offset zero, and with per-scope exemptions"). The released fhsim/3.2.0@sintef/stable recipe is built from 8f98caa6 (its conandata.yml), and git merge-base --is-ancestor b005ec27 8f98caa6 succeeds; fhsim/3.3.0@sintef/stable (41a573bf) contains it too. Both packaged headers declare it: include/fhsim/testtools/JacobianChecker.h:86 (3.2.0) and :87 (3.3.0), std::map<std::string, JacobianScopeOverride> scopeOverrides;.
  • Run, 2026-09-26: g++ -fsyntax-only tests/src/Template-Input_Test.cpp with the test target's flags and the fhsim include path pointed at each of the two local fhsim/3.2.0@sintef/stable packages exits 0. Against fhsim/3.1.0@sintef/stable it fails with "`struct fhsim::test::JacobianCheckConfig` has no member named `scopeOverrides`" at lines 21 and 39, which is the break the CHANGELOG describes, one release earlier than it says.
  • No fhsim/*@sintef/jaccheck package is in the local Conan cache (‘conan list 'fhsim/*’`).

Effect

A reader following the CHANGELOG or the testing report looks for a jaccheck channel that is not needed and not published, and believes the stable 3.2.0 cannot build the tests, which it can.

Possible fix

In CHANGELOG.md:29-31, replace the sentence with: this needs FhSim 3.2.0 or later, whose JacobianCheckConfig has scopeOverrides; the tests no longer compile against 3.1.0 (which conanfile.py no longer accepts). In doc/user/testing_report.md:66, replace fhsim/3.2.0@sintef/jaccheck with fhsim/3.2.0@sintef/stable. The resolved issue files that record the jaccheck build as where they were found stay as they are.

Test that would prove it

The syntax-only compile above, or a normal build of the tests against fhsim/3.2.0@sintef/stable.

Risk

Documentation only.